[Svnmerge] [PATCH] fix remaining test failures on Windows

Hernan Martinez Foffani hernan.martinez at ecc.es
Sun Jul 29 06:33:32 PDT 2007


svnmerge-bounces+hernan.martinez=ecc.es at orcaware.com wrote:
> On Thu, Jul 12, 2007 at 11:53:48AM +0200, Giovanni Bajo wrote:
>> At the very least, it should be using "wU" to create the commit log
>> file, instead of doing another pass over it.
>>
>> I'm planning to look at all these patches for the testsuite, but I
>> need to dig back to where it all started to make sure it's not a
>> whole lot of useless work.
>
> Mode 'wU' is illegal, according to PEP 278, and accordingly to the
> runtime help for 'open'.
>
> I've attached an updated patch to bug #2813 to use regexps and
> os.linesep to get the commit log messages right.  It works on Linux,
> but
> that's probably a given.  Luke, do you mind testing it on Windows?
>
>
>
http://subversion.tigris.org/nonav/issues/showattachment.cgi/688/fixWindowsL
ineTermFailures.patch
>
> Dustin

Well... I'm not Luke, but the guy that said he's using svnmerge.py
under Windows.  I'm sorry. I couldn't try your patch before.

I've never did the test before. How is it supposed to work?
Executing svnmerge_test.py on trunk gives several errors
(before and after applying your patch).

Regards,
-Hernan.






More information about the Svnmerge mailing list