[Svnmerge] [PATCH] fix remaining test failures on Windows

Giovanni Bajo rasky at develer.com
Tue Jul 31 08:00:46 PDT 2007


On 7/31/2007 2:36 PM, Michael Willmott wrote:

>> I've attached an updated patch to bug #2813 to use regexps and
>> os.linesep to get the commit log messages right.  It works on Linux, but
>> that's probably a given.  Luke, do you mind testing it on Windows?
> 
> Dustin, I've updated your patch based on my testing here.  The new patch 
> I've added to the bug passes the testsuite on my windows boxes here.
> 
> http://subversion.tigris.org/nonav/issues/showattachment.cgi/689/fixWindowsLineTermFailures-2.patch

I don't think that collapsing a sequence of \r or \n to a single \n is 
the right thing to do: it would destroy paragraph formatting.

Is a simple "message = message.replace("\r\n", "\n")" enough? If not, why?
-- 
Giovanni Bajo




More information about the Svnmerge mailing list