[Svnmerge] Obvious bugfix in VersionedProperty

Raman Gupta rocketraman at fastmail.fm
Tue Nov 13 12:05:22 PST 2007


Giovanni Bajo wrote:
> Hi,
> 
> an anonymous contributor sent in this patchlet:
> 
> Index: svnmerge.py
> ===================================================================
> --- svnmerge.py (revision 27789)
> +++ svnmerge.py (working copy)
> @@ -479,7 +479,7 @@
>                   self._changed_values.append(new_value)
>                   self.revs.append(rev)
>                   self.values.append(new_value)
> -                new_value = old_value
> +                old_value = new_value
> 
>           # Indicate that we know nothing about the value of the property
>           # after the range of the log.
> 
> 
> It looks like pretty obvious to me; basically, VersionedProperty was 
> caching more revisions than strictly necessary. It's not a correctness 
> issue at this point AFAICT, this is why it was not noticed before.

+1

Cheers,
Raman




More information about the Svnmerge mailing list