[Svnmerge] [PATCH] Indented log patch modified v5

Alan Barrett apb at cequrux.com
Wed Mar 1 21:33:55 PST 2006


On Wed, 01 Mar 2006, Raman Gupta wrote:
> One thing I don't like. Your prefix lines is inconsistent with the
> newlines. If the value passed has a newline at the end, it returns it.
> If the value passed does not have a newline at the end, it appends
> one.
>
> In the new patch I attached, I have used your new function, but
> changed the return value to be consistent with the passed value, as
> well as updated the test case.

That looks good.  I don't see any more issues.

> Note that I also fixed your indentation, and changed pop(lineslist) to
> lineslist.pop(). Is pop a recently added function that we should have
> a local replacement for?

Sorry, I don't know.

--apb (Alan Barrett)



More information about the Svnmerge mailing list