[Svnmerge] Re: [PATCH] svnmerge.py: Refactor analyze_revs

Giovanni Bajo rasky at develer.com
Fri Mar 3 03:05:49 PST 2006


David James <djames at collab.net> wrote:

>> +1 on the general idea and thanks for the cleanup. Some comments:
> Thanks! I committed my patch just before I saw your mail, in r18695.
> I've committed a followup in r18696 to address your suggestions.


Thanks!
To me, it's fine to address comments either in followups or before the actual
commit, as long as we still go through the code review process.

Giovanni Bajo




More information about the Svnmerge mailing list