[Svnmerge] svnmerge.py breaks in cron

[Dustin J. Mitchell]

On 10/24/07, Alan Barrett <apb at cequrux.com> wrote:
> 1. This needs to be in a try/except block, in case popen fails or stty
>    exits with an error, or something.
>
> 2. It's possible for TERM to be defined even if there's no terminal
>    available.  I'd suggest using os.isatty(), or simply relying on
>    try/except to catch any error (and not bothering with any sort of
>    pre-test).
>
> 3. You should probably set LC_ALL="C".  (Or is that already done at a
>    higher level?)
>
> 4. Even if stty works, there's no guarantee that it the output will
>    include the number of columns.  I see that you are already handling
>    that case.

All fair points.  Patch attached

Dustin

-- 
Storage Software Engineer
http://www.zmanda.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: stty-term.patch
Type: application/octet-stream
Size: 792 bytes
Desc: not available
Url : /pipermail/svnmerge/attachments/20071024/dfe3c7bb/attachment.obj