[Svnmerge] [PATCH] Prompt for source branch when multiple sourcesexist

Giovanni Bajo rasky at develer.com
Thu Apr 13 00:43:03 PDT 2006


The patch is outdated (after Madan's patch to list URLs) and should be
regenerated.

> I'm not a fan of this interactivity (why is it necessary?)

I'm not a fan either. IIRC, somebody posted and agreed it could be a good idea.
I'm basically -0 on it. I guess we should take a decision on this before
continuing. Jim has already provided a few iteration of this patch, and it
wouldn't be fair to ask for more modifications and later reject the idea.

>> +                    break
>> +                try:
>> +                    input = int(input)
>> +                    if not 0 <= input < len(props):
>> +                        raise ValueError
>> +                except ValueError:
>> +                    print 'Please enter a value between 0 and ' +
str(len(props)-1) + '!'
>> +                    input = None

> Is the use of exceptions appropriate here (e.g. does it make the code
> simpler or something)?

I suggested that. There's no easy way to know beforehand whether int(foo) will
succeed. Not easier than just trying it.

Giovanni Bajo




More information about the Svnmerge mailing list