[Svnmerge] [PATCH] fix failing test

Dustin J. Mitchell dustin at zmanda.com
Fri Apr 11 15:08:44 PDT 2008


I'm seeing the following:

======================================================================
ERROR: Init svnmerge, modify source head and commit with a message
----------------------------------------------------------------------
Traceback (most recent call last):
  File "svnmerge_test.py", line 1279, in testCommitMessageEncoding
    msg_file.write(commit_msg.encode(input_encoding))
TypeError: encode() argument 1 must be string, not None

locale.defaultlocale() returns (None,None) here.  The python
documentation says, "language code and encoding may be None if their
values cannot be determined".  I think that in this case the system is
not configured to handle any kind of encoding, so the whole test
should be skipped.  This seems to be what's done in
recode_stdout_to_file().

Are there better solutions?

Dustin

-- 
Storage Software Engineer
http://www.zmanda.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: skip_encoding_test.patch
Type: application/octet-stream
Size: 1344 bytes
Desc: not available
Url : /pipermail/svnmerge/attachments/20080411/f596009d/attachment.obj 


More information about the Svnmerge mailing list